-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new warning message about mismatching expected and actual platform doesn't "canonicalize" the input before comparison (ie aarch64 vs arm64) #14669
Comments
@vrothberg PTAL |
Thanks for reaching out, @Romain-Geissler-1A! It's unfortunate that aarch64 seems to be used in the wild as it's not an official GOARCH value (see https://gist.github.com/asukakenji/f15ba7e588ac42795f421b48b8aede63) and is not really covered by the OCI image spec. But conventions matter, so I am going to take a look. |
This lack of single convention is wider than just OCI images, for example it also creates issues for people packaging .deb and .rpm for their software where one uses one convention and the other one uses the other convention. On the OCI side, IMO it's very important that container engine understand/accept $(uname -m) output, we use it in many places on our side to build multi-arch images. Shall there be some simple coreutils tools allowing to convert to the other naming convention, we would use it, but I don't think it exists and I don't want to write in every single of my scripts if ($(uname) -m == "x86_64") then OCIArch = "amd64" else if .... |
Thanks for elaborating, @Romain-Geissler-1A! I agree, the |
Fixes: #containers/podman/issues/14669 Signed-off-by: Valentin Rothberg <[email protected]>
Use containerd's platform package for platform checks. While the OCI image spec requires the platform values to conform with GOOS and GOARCH definitions of Go' runtime package, the values of uname are used by convention. Supporting these values silences annoying false-positive warnings. Fixes: #containers/podman/issues/14669 Signed-off-by: Valentin Rothberg <[email protected]>
Pull in fixes for platform checks to silence annoying warnings when pulling images by platforms using uname values. Fixes: containers#14669 Signed-off-by: Valentin Rothberg <[email protected]>
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
The new warning message about mismatching expected and actual platform doesn't "canonicalize" the input before comparison (ie aarch64 vs arm64).
Steps to reproduce the issue:
Describe the results you received:
We have this warning:
WARNING: image platform (linux/arm64) does not match the expected platform (linux/aarch64)
Describe the results you expected:
No warning should be printed in this case (as normally "linux/aarch64" shall be "canonicalized" to "linux/arm64" before comparison, like Docker does).
Additional information you deem important (e.g. issue happens only occasionally):
Output of
podman version
:The text was updated successfully, but these errors were encountered: