Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman system connection ls --format json: remove star from default Name please #12019

Closed
edsantiago opened this issue Oct 18, 2021 · 0 comments · Fixed by #12027
Closed

podman system connection ls --format json: remove star from default Name please #12019

edsantiago opened this issue Oct 18, 2021 · 0 comments · Fixed by #12027
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

The asterisk is, I guess, OK in the table format (although I would suggest that it would be better as a separate column):

$ bin/podman-remote system connection ls
Name                 Identity    URI
a1 (default)                     tcp://localhost:55555
a2                               tcp://localhost:55555

When emitting json, though, the '*' is antihelpful, and forces the user to jump through hoops to remove it:

[
    {
        "Name": "a1*",
        "URI": "tcp://localhost:55555",
        "Identity": ""
    },
    {
        "Name": "a2",
        "URI": "tcp://localhost:55555",
        "Identity": ""
    }
]

Perhaps a new IsDefault field?

rhatdan added a commit to rhatdan/podman that referenced this issue Oct 18, 2021
Stop using "*" to indicate default.  Add default field to make
it more obvios and the json field more machine usable.

Fixes: containers#12019

Signed-off-by: Daniel J Walsh <[email protected]>
@jwhonce jwhonce added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants