generate kube -s: do not insert annotations for the bind in the service yaml

[dilyanpalauzov]

I run a podman container as described at https://mail.aegee.org/cgit/aegee-ldap/tree/readme.md#n13 . Then call podman generate kube -s busy_mclaren. The output is:

# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-3.4.0
apiVersion: v1
kind: Service
metadata:
  annotations:
    bind-mount-options:/home/d/data: Z
  creationTimestamp: "2021-10-12T05:51:48Z"
  labels:
    app: busymclaren
  name: busymclaren
spec:
  ports:
  - name: "3890"
    nodePort: 31091
    port: 3890
    protocol: TCP
    targetPort: 0
  selector:
    app: busymclaren
  type: NodePort
status:
  loadBalancer: {}

Apart from the fact, that the annotation is syntactically not accepted by kubelet apply -f, such annotations have nothing to do with the Service and therefore shall not be emitted.

[rhatdan]

@baude PTAL

[rhatdan]

Seems this is a duplicate of #11930

[dilyanpalauzov]

This ticket is about the useless anotation, the other ticket is about targetPort:0.

[mheon]

It's useless for Kube, but it's necessary for preserving this information for podman play kube - one of our goals is that podman play kube on YAML from podman generate kube should produce close-to-identical containers. Podman containers and Kube YAML are not perfectly matched, hence the need for such annotations.

[dilyanpalauzov]

The annotation is included in the Pod and in the Service object. I mean, that it is sufficient to include the annotation only in the Pod object.

[mheon]

Ahh, fair.

[rhatdan]

Interested in opening a PR to fix it?

[dilyanpalauzov]

I am not interested.

[baude]

would changing where it is in the stanza be a breaking change though?

[dilyanpalauzov]

This ticket is not about the syntactically invalid annotation.

This ticket is about the unnecessary annotation in the Service yaml output.

[rhatdan]

Not if nothing uses it.

[dilyanpalauzov]

I use the latest podman - commit 171f7b8 - and I see no difference in the output of podman generate kube -s - the generated annotation is syntactically invalid. The bind annotation is included both in the Pod.metadata and Service.metadata . including the bind annotation in Service.metadata seems unnecessary.