Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman system service: takes 4-6s to clean up on interrupt #11921

Closed
edsantiago opened this issue Oct 11, 2021 · 3 comments · Fixed by #11927
Closed

podman system service: takes 4-6s to clean up on interrupt #11921

edsantiago opened this issue Oct 11, 2021 · 3 comments · Fixed by #11927
Assignees
Labels
flakes Flakes from Continuous Integration In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. rootless

Comments

@edsantiago
Copy link
Member

New flake. It's a one-off, but ISTR something new last week dealing with pprof, so am filing with just one single data point:

podman system service verify pprof endpoints [It] are available

podman system service verify pprof endpoints [It] are not available

(all links are to the same log, same run).

(Tagging as rootless but that may just be serendipity. I will remove the tag if I see a failed root run).

@Luap99
Copy link
Member

Luap99 commented Oct 11, 2021

@jwhonce PTAL

@jwhonce
Copy link
Member

jwhonce commented Oct 11, 2021

@edsantiago While in server.go for the pprof work, I "fixed" the issue where the API service was not shutdown in an orderly manner when --time=0. At the given logging level for these tests, I cannot determine if they were spurious but I will try to recreate on my laptop.

@jwhonce jwhonce self-assigned this Oct 11, 2021
@jwhonce jwhonce added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Oct 11, 2021
@edsantiago
Copy link
Member Author

...and, another one. I get the feeling this might soon become our number-one flake.

@edsantiago edsantiago changed the title pprof: IdleTracker: StateClosed transition by connection marked un-managed podman system service: takes 4-6s to clean up on interrupt Oct 12, 2021
jwhonce added a commit to jwhonce/podman that referenced this issue Oct 12, 2021
* Increase timeout for tests to 10s
* To aid in debugging add PID to shutdown package logging
* Added new message for forced service shutdown
* Always wait for HTTP server to shutdown, duration of 0 not friendly
  to clients

Note: The log event

"IdleTracker: StateClosed transition by connection marked un-managed"

denotes a TCP connection has been initiated but no HTTP request was sent.
And is expected during these tests.

Fixes containers#11921

Signed-off-by: Jhon Honce <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. rootless
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants