podman inspect returns State.Healthcheck when docker uses State.Health

[abitrolly]

/kind bug

Description

Scripts that check health of containers are incompatible between docker and podman.

Steps to reproduce the issue:

1. Run a container with a healthcheck and then inspect it with docker

$ docker inspect --format "{{json .State }}" warehouse_db_1 | jq
{
  "Status": "exited",
  "Running": false,
  "Paused": false,
  "Restarting": false,
  "OOMKilled": false,
  "Dead": false,
  "Pid": 0,
  "ExitCode": 0,
  "Error": "",
  "StartedAt": "2021-09-18T12:59:02.996240627Z",
  "FinishedAt": "2021-09-18T13:21:01.053654425Z",
  "Health": {
    "Status": "unhealthy",
    "FailingStreak": 0,
    "Log": [
      {
        "Start": "2021-09-18T13:20:39.925990714Z",
...

2. The run the container with podman and inspect it as well.

$ podman inspect --format "{{json .State }}" warehouse_db_1 | jq
{
  "OciVersion": "1.0.2-dev",
  "Status": "configured",
  "Running": false,
  "Paused": false,
  "Restarting": false,
  "OOMKilled": false,
  "Dead": false,
  "Pid": 0,
  "ExitCode": 0,
  "Error": "",
  "StartedAt": "0001-01-01T00:00:00Z",
  "FinishedAt": "0001-01-01T00:00:00Z",
  "Healthcheck": {
    "Status": "",
    "FailingStreak": 0,
    "Log": null
  }
}

Describe the results you received:

podman uses State.Healthcheck,Status
docker uses State.Health.Status

Describe the results you expected:

Both use State.Health.Status.

Output of podman version:

$ podman version
Version:      3.3.1
API Version:  3.3.1
Go Version:   go1.16.6
Built:        Thu Jan  1 00:00:00 1970
OS/Arch:      linux/amd64

Additional environment details (AWS, VirtualBox, physical, etc.):

$ docker version
Client: Docker Engine - Community
 Version:           19.03.13
 API version:       1.40
 Go version:        go1.13.15
 Git commit:        4484c46d9d
 Built:             Wed Sep 16 17:02:36 2020
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.13
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       4484c46d9d
  Built:            Wed Sep 16 17:01:06 2020
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.4.9
  GitCommit:        e25210fe30a0a703442421b0f60afac609f950a3
 runc:
  Version:          1.0.1
  GitCommit:        v1.0.1-0-g4144b63
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

[Luap99]

Is it ok for you to only add Health as method to the struct, this would make {{json .State.Health }} work but {{json .State }} will still not include the Health key.

[abitrolly]

@Luap99 not really. The reason I spotted this is because I was developing my scripts with podman and they've failed when run by GitHub Actions with docker. I spent a lot of time trying to debug what is going on.