Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDG_RUNTIME_DIR is pointing to a path which is not writable. Most likely podman will fail #11521

Closed
Luap99 opened this issue Sep 10, 2021 · 11 comments · Fixed by #11523
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@Luap99
Copy link
Member

Luap99 commented Sep 10, 2021

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

All integration test logs now have this warning for each podman command
time="2021-09-10T08:35:26Z" level=warning msg="XDG_RUNTIME_DIR is pointing to a path which is not writable. Most likely podman will fail."

Steps to reproduce the issue:
Look at any recent integration test logs (rootless).

Describe the results you expected:
This warning should not be there. It makes it impossible to exactly match output.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 10, 2021
@Luap99
Copy link
Member Author

Luap99 commented Sep 10, 2021

@flouthoc PTAL
cc @edsantiago

@flouthoc
Copy link
Collaborator

@Luap99 hmm this is a weird blocker , should we have a quit flag for tests ? as this warning was specifically meant for users. I'll check this. Thanks for creating this issue.

We can de-escalate this to debug log but then the whole purpose of warning would go away.

Btw this is only triggered

  • Session is rootless && cgroupv2 && systemdsession is invalid && XDG_RUNTIME_DIR is not writable

@flouthoc
Copy link
Collaborator

Also curious about how did CI pass for this I guess any of the old tests are not doing exact match in this specific case. Except for changes in this PR right #11513 @Luap99 ?

@Luap99
Copy link
Member Author

Luap99 commented Sep 10, 2021

This is cluttering the logs with useless warnings. This is big problem for me. I am sure @edsantiago agrees.
The test are running successfully, that means that we are given a warning if there is no error! Yes the STDERR output is almost never checked in tests so this passed in your PR without problems. However some test might require to check for no output on STDERR like my PR.

Why is this warning shown in CI tests, the runroot is obviously writeable. I think the problem is that the directory does not exist when the check is made but podman will automatically create it at a later point.

@flouthoc
Copy link
Collaborator

@Luap99 This makes sense we can create the dir if it does not exists or move the check just after the directory is created. That should suppress warning for most of the cases.

@Luap99
Copy link
Member Author

Luap99 commented Sep 10, 2021

Why do we check the systemd session or cgroupv2? I think we should just check if the dir is writable. As long as the dir is not writable people will always run into problems.

Luap99 added a commit to Luap99/libpod that referenced this issue Sep 10, 2021
The rootless integration tests show the XDG_RUNTIME_DIR warning without
any reasons. Podman runs without problems in these and yet the warning
is shown. I think the problem is that we check the permission before we
create the runroot directory.

[NO TESTS NEEDED]

Fixes containers#11521

Signed-off-by: Paul Holzinger <[email protected]>
@flouthoc
Copy link
Collaborator

@Luap99 Podman fall backs to temp and things work out fine in most of the cases when its cgroup v1

@flouthoc
Copy link
Collaborator

flouthoc commented Sep 10, 2021

since everything falls back to cgroupfs

@flouthoc
Copy link
Collaborator

Some of the key points are discussed here as well #11327

@giuseppe
Copy link
Member

@flouthoc this is not a serious issue. You don't have to look at it during your day off.

I'll take a look at it

@flouthoc
Copy link
Collaborator

thanks @giuseppe @Luap99 :)

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants