Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation indicates that the --driver option only supports bridged networking. #11400

Closed
dataegg opened this issue Sep 1, 2021 · 0 comments · Fixed by #11402
Closed

Documentation indicates that the --driver option only supports bridged networking. #11400

dataegg opened this issue Sep 1, 2021 · 0 comments · Fixed by #11402
Assignees
@Luap99
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@dataegg
Copy link

dataegg commented Sep 1, 2021

/kind bug

Description

Documentation issue

The documentation (https://docs.podman.io/en/latest/markdown/podman-network-create.1.html) describes that the --driver option only supports bridged networking while later in the documentation it says that the --macvlan option is deprecated.

This would create a situation where there is no more macvlan network option. The --driver option also supports the macvlan option and this should be included in the documentation as well

The release notes (https://github.com/containers/podman/releases/tag/v3.0.0) indicate that the --driver option supports macvlan networking.
@Luap99 Luap99 self-assigned this Sep 2, 2021
@Luap99 Luap99 added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Sep 2, 2021
@Luap99 Luap99 mentioned this issue Sep 2, 2021
Merged
Luap99 added a commit to Luap99/libpod that referenced this issue Sep 7, 2021
@Luap99
network create: add warning for deprecated macvlan flag
3d02cfb 
The macvlan driver is not deprecated, only the --macvlan flag is.
Remove the flag from the man page since it is deprecated and add a
warning to podman network create if it is used.

[NO TESTS NEEDED]

Fixes containers#11400

Signed-off-by: Paul Holzinger <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

network create: add warning for deprecated macvlan flag Luap99/libpod
2 participants
@dataegg @Luap99