Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: pod infra container name customization #10794

Closed
mskarbek opened this issue Jun 27, 2021 · 4 comments · Fixed by #10820
Closed

RFE: pod infra container name customization #10794

mskarbek opened this issue Jun 27, 2021 · 4 comments · Fixed by #10820
Assignees
@jvanz
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@mskarbek
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

I would like to be able to set name for infra container created inside pod, Additional option in podman pod create in form of --infra-name=name should be ok. Reasoning: we are using strict naming convention for pods/containers and only infra containers require additional code path to handle its naming divergence.
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2021
@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2021

Interested in opening a PR to fix this?

@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Jun 28, 2021
@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2021

@cdoern Interested in taking a look at this?

@jvanz
Copy link
Contributor

jvanz commented Jun 29, 2021

Can I work on this? Thanks!

@rhatdan
Copy link
Member

rhatdan commented Jun 29, 2021

Sure we love free labor...

@jvanz jvanz mentioned this issue Jun 29, 2021
Merged
jvanz added a commit to jvanz/libpod that referenced this issue Jul 16, 2021
@jvanz
--infra-name command line argument
af40dfc 
Adds the new --infra-name command line argument allowing users to define
the name of the infra container

Issue containers#10794

Signed-off-by: José Guilherme Vanz <[email protected]>
@polski-g polski-g mentioned this issue Oct 21, 2021
Closed
@Sani7 Sani7 mentioned this issue Apr 23, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jvanz jvanz

Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

--infra-name command line argument jvanz/libpod
3 participants
@jvanz @mskarbek @rhatdan