Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote events seems to lose data #10529

Closed
vrothberg opened this issue Jun 2, 2021 · 0 comments · Fixed by #10558
Closed

remote events seems to lose data #10529

vrothberg opened this issue Jun 2, 2021 · 0 comments · Fixed by #10558
Assignees
@vrothberg
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@vrothberg
Copy link
Member

podman-remote events seems to lose data that the local client displays reliably (detected in #10514). For reproducers, look for this issue's number in test/system.
@vrothberg vrothberg added the kind/bug Categorizes issue or PR as related to a bug. label Jun 2, 2021
@vrothberg vrothberg mentioned this issue Jun 2, 2021
Merged
@vrothberg vrothberg self-assigned this Jun 4, 2021
@vrothberg vrothberg added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Jun 4, 2021
@vrothberg vrothberg mentioned this issue Jun 4, 2021
Merged
vrothberg added a commit to vrothberg/libpod that referenced this issue Jun 4, 2021
@vrothberg
remote events: fix --stream=false
86610c7 
Fix a bug in remote events where only one event would be sent if when
streaming is turned off.  The source of the bug was that the handler
attempted to implement the streaming logic and did it wrong.  The fix is
rather simple by removing this logic from the handler and let the events
backend handle streaming.

Fixes: containers#10529
Signed-off-by: Valentin Rothberg <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Jun 11, 2021
@vrothberg @mheon
remote events: fix --stream=false
5a15856 
Fix a bug in remote events where only one event would be sent if when
streaming is turned off.  The source of the bug was that the handler
attempted to implement the streaming logic and did it wrong.  The fix is
rather simple by removing this logic from the handler and let the events
backend handle streaming.

Fixes: containers#10529
Signed-off-by: Valentin Rothberg <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remote events: fix --stream=false vrothberg/libpod
1 participant
@vrothberg