Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: secrets command links 404 #10513

Closed
Mossman1215 opened this issue May 31, 2021 · 11 comments · Fixed by #10523
Closed

Docs: secrets command links 404 #10513

Mossman1215 opened this issue May 31, 2021 · 11 comments · Fixed by #10523
Labels
documentation Issue or fix is in project documentation kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@Mossman1215
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

I can't find the documentation for podman-secrets-create command on the first google search result because the links in the upper level documentation don't work

Steps to reproduce the issue:

  1. browse to http://docs.podman.io/en/latest/Commands.html

  2. click the link to secret

  3. click any of the sub command links

image

  1. get a maze found page instead of linking to the published link http://docs.podman.io/en/latest/markdown/podman-secret-create.1.html

Describe the results you received:
404 errors 😢

Describe the results you expected:

Unlike the pod command, the pages for secrets have .1.html attached which seems wrong

Additional information you deem important (e.g. issue happens only occasionally):

I'm assuming that link.lua is supposed to rename the output to .html but that hasn't worked.

I've run the build process locally and also had the same outputs and 404 page
Screenshot from 2021-06-01 11-04-54

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 31, 2021
@Mossman1215
Copy link
Author

Please let me know if there are any further things I can test.

@zhangguanzhang zhangguanzhang added the documentation Issue or fix is in project documentation label Jun 1, 2021
@vrothberg
Copy link
Member

Thanks for opening the issue!

@baude PTAL

rhatdan added a commit to rhatdan/podman that referenced this issue Jun 1, 2021
This change makes secrets and machine handling match the handling of
other subcommands of Podman.

Possible fixes: containers#10513

Signed-off-by: Daniel J Walsh <[email protected]>
@zhangguanzhang
Copy link
Collaborator

@zhangguanzhang zhangguanzhang reopened this Jun 2, 2021
@rhatdan
Copy link
Member

rhatdan commented Jun 2, 2021

Those should be fixed by the update.

@vrothberg
Copy link
Member

I just tested, it works now. Thanks!

@Mossman1215
Copy link
Author

thanks!

@zhangguanzhang
Copy link
Collaborator

zhangguanzhang commented Jun 3, 2021

http://docs.podman.io/en/latest/markdown/podman-secret-create.1.md
still happend, may be the CDN in my network?

@rhatdan
Copy link
Member

rhatdan commented Jun 7, 2021

How do you get to that link?

@rhatdan
Copy link
Member

rhatdan commented Jun 7, 2021

@zhangguanzhang
Copy link
Collaborator

now , it works

@rhatdan
Copy link
Member

rhatdan commented Jun 8, 2021

Awesome, thanks for confirming.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Issue or fix is in project documentation kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants