volume: move validating volume dest from client to server.

[NO TESTS NEEDED] Signed-off-by: flouthoc <[email protected]>
containers · Aug 16, 2021 · f985699 · f985699
1 parent a38d753
commit f985699
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/libpod/options.go b/libpod/options.go
@@ -1456,6 +1456,10 @@ func WithNamedVolumes(volumes []*ContainerNamedVolume) CtrCreateOption {
 				return errors.Wrapf(err, "error processing options for named volume %q mounted at %q", vol.Name, vol.Dest)
 			}
 
+			if err = parse.ValidateVolumeCtrDir(vol.Dest); err != nil {
+				return errors.Wrapf(err, "error validating destination path for named volume %q mounted at %q", vol.Name, vol.Dest)
+			}
+
 			ctr.config.NamedVolumes = append(ctr.config.NamedVolumes, &ContainerNamedVolume{
 				Name:    vol.Name,
 				Dest:    vol.Dest,

diff --git a/pkg/specgen/volumes.go b/pkg/specgen/volumes.go
@@ -93,9 +93,6 @@ func GenVolumeMounts(volumeFlag []string) (map[string]spec.Mount, map[string]*Na
 				return nil, nil, nil, errors.New("host directory cannot be empty")
 			}
 		}
-		if err := parse.ValidateVolumeCtrDir(dest); err != nil {
-			return nil, nil, nil, err
-		}
 
 		cleanDest := filepath.Clean(dest)