Skip to content

Commit

Permalink
Merge pull request #13798 from n1hility/fix-docker-sock
Browse files Browse the repository at this point in the history
Fix mac docker socket handling
  • Loading branch information
openshift-merge-robot authored Apr 7, 2022
2 parents d7ff08a + 356d534 commit f838333
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion pkg/machine/qemu/machine.go
Original file line number Diff line number Diff line change
Expand Up @@ -1133,11 +1133,16 @@ func (v *MachineVM) setupAPIForwarding(cmd []string) ([]string, string, apiForwa
cmd = append(cmd, []string{"-forward-dest", destSock}...)
cmd = append(cmd, []string{"-forward-user", forwardUser}...)
cmd = append(cmd, []string{"-forward-identity", v.IdentityPath}...)
link := socket.GetPath()

// The linking pattern is /var/run/docker.sock -> user global sock (link) -> machine sock (socket)
// This allows the helper to only have to maintain one constant target to the user, which can be
// repositioned without updating docker.sock.

link, err := v.userGlobalSocketLink()
if err != nil {
return cmd, socket.GetPath(), machineLocal
}

if !dockerClaimSupported() {
return cmd, socket.GetPath(), claimUnsupported
}
Expand Down Expand Up @@ -1176,6 +1181,16 @@ func (v *MachineVM) isIncompatible() bool {
return v.UID == -1
}

func (v *MachineVM) userGlobalSocketLink() (string, error) {
path, err := machine.GetDataDir(v.Name)
if err != nil {
logrus.Errorf("Resolving data dir: %s", err.Error())
return "", err
}
// User global socket is located in parent directory of machine dirs (one per user)
return filepath.Join(filepath.Dir(path), "podman.sock"), err
}

func (v *MachineVM) forwardSocketPath() (*MachineFile, error) {
sockName := "podman.sock"
path, err := machine.GetDataDir(v.Name)
Expand Down

0 comments on commit f838333

Please sign in to comment.