-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This involves a new test binary (a basic implementation of the volume plugin protocol) and a new image on quay.io (Containerfile to produce it and all sources located in this commit). The image is used to run a containerized plugin we can test against. Signed-off-by: Matthew Heon <[email protected]>
- Loading branch information
Showing
9 changed files
with
529 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| FROM golang:1.15-alpine AS build-img | ||
| COPY ./test/testvol/ /go/src/github.com/containers/podman/cmd/testvol/ | ||
| COPY ./vendor /go/src/github.com/containers/podman/vendor/ | ||
| WORKDIR /go/src/github.com/containers/podman | ||
| RUN go build -o /testvol ./cmd/testvol | ||
|
|
||
| FROM alpine | ||
| COPY --from=build-img /testvol /usr/local/bin | ||
| WORKDIR / | ||
| ENTRYPOINT ["/usr/local/bin/testvol"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| package integration | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "path/filepath" | ||
|
|
||
| . "github.com/containers/podman/v2/test/utils" | ||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| var _ = Describe("Podman volume plugins", func() { | ||
| var ( | ||
| tempdir string | ||
| err error | ||
| podmanTest *PodmanTestIntegration | ||
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| tempdir, err = CreateTempDirInTempDir() | ||
| if err != nil { | ||
| os.Exit(1) | ||
| } | ||
| podmanTest = PodmanTestCreate(tempdir) | ||
| podmanTest.Setup() | ||
| podmanTest.SeedImages() | ||
| os.Setenv("CONTAINERS_CONF", "config/containers.conf") | ||
| SkipIfRemote("Volume plugins only supported as local") | ||
| SkipIfRootless("Root is required for volume plugin testing") | ||
| os.MkdirAll("/run/docker/plugins", 0755) | ||
| }) | ||
|
|
||
| AfterEach(func() { | ||
| podmanTest.CleanupVolume() | ||
| f := CurrentGinkgoTestDescription() | ||
| processTestResult(f) | ||
| os.Unsetenv("CONTAINERS_CONF") | ||
| }) | ||
|
|
||
| It("volume create with nonexistent plugin errors", func() { | ||
| session := podmanTest.Podman([]string{"volume", "create", "--driver", "notexist", "test_volume_name"}) | ||
| session.WaitWithDefaultTimeout() | ||
| Expect(session.ExitCode()).To(Not(Equal(0))) | ||
| }) | ||
|
|
||
| It("volume create with not-running plugin does not error", func() { | ||
| session := podmanTest.Podman([]string{"volume", "create", "--driver", "testvol0", "test_volume_name"}) | ||
| session.WaitWithDefaultTimeout() | ||
| Expect(session.ExitCode()).To(Not(Equal(0))) | ||
| }) | ||
|
|
||
| It("volume create and remove with running plugin succeeds", func() { | ||
| podmanTest.AddImageToRWStore(volumeTest) | ||
|
|
||
| pluginStatePath := filepath.Join(podmanTest.TempDir, "volumes") | ||
| os.Mkdir(pluginStatePath, 0755) | ||
|
|
||
| // Keep this distinct within tests to avoid multiple tests using the same plugin. | ||
| pluginName := "testvol1" | ||
| plugin := podmanTest.Podman([]string{"run", "--security-opt", "label=disable", "-v", "/run/docker/plugins:/run/docker/plugins", "-v", fmt.Sprintf("%v:%v", pluginStatePath, pluginStatePath), "-d", volumeTest, "--sock-name", pluginName, "--path", pluginStatePath}) | ||
| plugin.WaitWithDefaultTimeout() | ||
| Expect(plugin.ExitCode()).To(Equal(0)) | ||
|
|
||
| volName := "testVolume1" | ||
| create := podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, volName}) | ||
| create.WaitWithDefaultTimeout() | ||
| Expect(create.ExitCode()).To(Equal(0)) | ||
|
|
||
| ls1 := podmanTest.Podman([]string{"volume", "ls", "-q"}) | ||
| ls1.WaitWithDefaultTimeout() | ||
| Expect(ls1.ExitCode()).To(Equal(0)) | ||
| arrOutput := ls1.OutputToStringArray() | ||
| Expect(len(arrOutput)).To(Equal(1)) | ||
| Expect(arrOutput[0]).To(ContainSubstring(volName)) | ||
|
|
||
| remove := podmanTest.Podman([]string{"volume", "rm", volName}) | ||
| remove.WaitWithDefaultTimeout() | ||
| Expect(remove.ExitCode()).To(Equal(0)) | ||
|
|
||
| ls2 := podmanTest.Podman([]string{"volume", "ls", "-q"}) | ||
| ls2.WaitWithDefaultTimeout() | ||
| Expect(ls2.ExitCode()).To(Equal(0)) | ||
| Expect(len(ls2.OutputToStringArray())).To(Equal(0)) | ||
| }) | ||
|
|
||
| It("volume inspect with running plugin succeeds", func() { | ||
| podmanTest.AddImageToRWStore(volumeTest) | ||
|
|
||
| pluginStatePath := filepath.Join(podmanTest.TempDir, "volumes") | ||
| os.Mkdir(pluginStatePath, 0755) | ||
|
|
||
| // Keep this distinct within tests to avoid multiple tests using the same plugin. | ||
| pluginName := "testvol2" | ||
| plugin := podmanTest.Podman([]string{"run", "--security-opt", "label=disable", "-v", "/run/docker/plugins:/run/docker/plugins", "-v", fmt.Sprintf("%v:%v", pluginStatePath, pluginStatePath), "-d", volumeTest, "--sock-name", pluginName, "--path", pluginStatePath}) | ||
| plugin.WaitWithDefaultTimeout() | ||
| Expect(plugin.ExitCode()).To(Equal(0)) | ||
|
|
||
| volName := "testVolume1" | ||
| create := podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, volName}) | ||
| create.WaitWithDefaultTimeout() | ||
| Expect(create.ExitCode()).To(Equal(0)) | ||
|
|
||
| volInspect := podmanTest.Podman([]string{"volume", "inspect", "--format", "{{ .Driver }}", volName}) | ||
| volInspect.WaitWithDefaultTimeout() | ||
| Expect(volInspect.ExitCode()).To(Equal(0)) | ||
| Expect(volInspect.OutputToString()).To(ContainSubstring(pluginName)) | ||
| }) | ||
|
|
||
| It("remove plugin with stopped plugin succeeds", func() { | ||
| podmanTest.AddImageToRWStore(volumeTest) | ||
|
|
||
| pluginStatePath := filepath.Join(podmanTest.TempDir, "volumes") | ||
| os.Mkdir(pluginStatePath, 0755) | ||
|
|
||
| // Keep this distinct within tests to avoid multiple tests using the same plugin. | ||
| pluginName := "testvol3" | ||
| ctrName := "pluginCtr" | ||
| plugin := podmanTest.Podman([]string{"run", "--name", ctrName, "--security-opt", "label=disable", "-v", "/run/docker/plugins:/run/docker/plugins", "-v", fmt.Sprintf("%v:%v", pluginStatePath, pluginStatePath), "-d", volumeTest, "--sock-name", pluginName, "--path", pluginStatePath}) | ||
| plugin.WaitWithDefaultTimeout() | ||
| Expect(plugin.ExitCode()).To(Equal(0)) | ||
|
|
||
| volName := "testVolume1" | ||
| create := podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, volName}) | ||
| create.WaitWithDefaultTimeout() | ||
| Expect(create.ExitCode()).To(Equal(0)) | ||
|
|
||
| ls1 := podmanTest.Podman([]string{"volume", "ls", "-q"}) | ||
| ls1.WaitWithDefaultTimeout() | ||
| Expect(ls1.ExitCode()).To(Equal(0)) | ||
| arrOutput := ls1.OutputToStringArray() | ||
| Expect(len(arrOutput)).To(Equal(1)) | ||
| Expect(arrOutput[0]).To(ContainSubstring(volName)) | ||
|
|
||
| stop := podmanTest.Podman([]string{"stop", "--timeout", "0", ctrName}) | ||
| stop.WaitWithDefaultTimeout() | ||
| Expect(stop.ExitCode()).To(Equal(0)) | ||
|
|
||
| // Remove should exit non-zero because missing plugin | ||
| remove := podmanTest.Podman([]string{"volume", "rm", volName}) | ||
| remove.WaitWithDefaultTimeout() | ||
| Expect(remove.ExitCode()).To(Not(Equal(0))) | ||
|
|
||
| // But the volume should still be gone | ||
| ls2 := podmanTest.Podman([]string{"volume", "ls", "-q"}) | ||
| ls2.WaitWithDefaultTimeout() | ||
| Expect(ls2.ExitCode()).To(Equal(0)) | ||
| Expect(len(ls2.OutputToStringArray())).To(Equal(0)) | ||
| }) | ||
|
|
||
| It("use plugin in containers", func() { | ||
| podmanTest.AddImageToRWStore(volumeTest) | ||
|
|
||
| pluginStatePath := filepath.Join(podmanTest.TempDir, "volumes") | ||
| os.Mkdir(pluginStatePath, 0755) | ||
|
|
||
| // Keep this distinct within tests to avoid multiple tests using the same plugin. | ||
| pluginName := "testvol4" | ||
| plugin := podmanTest.Podman([]string{"run", "--security-opt", "label=disable", "-v", "/run/docker/plugins:/run/docker/plugins", "-v", fmt.Sprintf("%v:%v", pluginStatePath, pluginStatePath), "-d", volumeTest, "--sock-name", pluginName, "--path", pluginStatePath}) | ||
| plugin.WaitWithDefaultTimeout() | ||
| Expect(plugin.ExitCode()).To(Equal(0)) | ||
|
|
||
| volName := "testVolume1" | ||
| create := podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, volName}) | ||
| create.WaitWithDefaultTimeout() | ||
| Expect(create.ExitCode()).To(Equal(0)) | ||
|
|
||
| ctr1 := podmanTest.Podman([]string{"run", "--security-opt", "label=disable", "-v", fmt.Sprintf("%v:/test", volName), ALPINE, "sh", "-c", "touch /test/testfile && echo helloworld > /test/testfile"}) | ||
| ctr1.WaitWithDefaultTimeout() | ||
| Expect(ctr1.ExitCode()).To(Equal(0)) | ||
|
|
||
| ctr2 := podmanTest.Podman([]string{"run", "--security-opt", "label=disable", "-v", fmt.Sprintf("%v:/test", volName), ALPINE, "cat", "/test/testfile"}) | ||
| ctr2.WaitWithDefaultTimeout() | ||
| Expect(ctr2.ExitCode()).To(Equal(0)) | ||
| Expect(ctr2.OutputToString()).To(ContainSubstring("helloworld")) | ||
|
|
||
| // HACK: `volume rm -f` is timing out trying to remove containers using the volume. | ||
| // Solution: remove them manually... | ||
| // TODO: fix this when I get back | ||
| rmAll := podmanTest.Podman([]string{"rm", "-af"}) | ||
| rmAll.WaitWithDefaultTimeout() | ||
| Expect(rmAll.ExitCode()).To(Equal(0)) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.