Skip to content

Commit

Permalink
Merge pull request #12229 from edsantiago/minor_test_tweaks
Browse files Browse the repository at this point in the history
Minor test tweaks
  • Loading branch information
openshift-merge-robot authored Nov 8, 2021
2 parents 3a31ac5 + 2ed31f9 commit ec37d35
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
8 changes: 1 addition & 7 deletions contrib/cirrus/pr-should-include-tests
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ fi
if [[ "${CIRRUS_CHANGE_MESSAGE}" =~ NO.NEW.TESTS.NEEDED ]]; then
exit 0
fi
if [[ "${CIRRUS_CHANGE_MESSAGE}" =~ NO.TESTS.NEEDED ]]; then
exit 0
fi

# HEAD should be good enough, but the CIRRUS envariable allows us to test
head=${CIRRUS_CHANGE_IN_REPO:-HEAD}
Expand Down Expand Up @@ -52,14 +49,11 @@ if [[ -z "$filtered_changes" ]]; then
exit 0
fi

# One last chance: perhaps the developer included the magic '[NO (NEW) TESTS NEEDED]'
# One last chance: perhaps the developer included the magic '[NO NEW TESTS NEEDED]'
# string in an amended commit.
if git log --format=%B ${base}..${head} | fgrep '[NO NEW TESTS NEEDED]'; then
exit 0
fi
if git log --format=%B ${base}..${head} | fgrep '[NO TESTS NEEDED]'; then
exit 0
fi

cat <<EOF
$(basename $0): PR does not include changes in the 'tests' directory
Expand Down
7 changes: 7 additions & 0 deletions test/system/500-networking.bats
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,13 @@ load helpers
$IMAGE nc -l -n -v -p $myport
cid="$output"

# FIXME: debugging for #11871
run_podman exec $cid cat /etc/resolv.conf
if is_rootless; then
run_podman unshare --rootless-cni cat /etc/resolv.conf
fi
ps uxww

# check that dns is working inside the container
run_podman exec $cid nslookup google.com

Expand Down

0 comments on commit ec37d35

Please sign in to comment.