Merge pull request #16323 from mheon/lock_during_kill

Ensure that StartAndAttach locks while sending signals
containers · Oct 28, 2022 · d444c2c · d444c2c
2 parents 25b5ee6 + 871172e
commit d444c2c
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/libpod/container_api.go b/libpod/container_api.go
@@ -282,6 +282,8 @@ func (c *Container) Attach(streams *define.AttachStreams, keys string, resize <-
 	if c.Terminal() {
 		go func() {
 			<-attachRdy
+			c.lock.Lock()
+			defer c.lock.Unlock()
 			if err := c.ociRuntime.KillContainer(c, uint(signal.SIGWINCH), false); err != nil {
 				logrus.Warnf("Unable to send SIGWINCH to container %s after attach: %v", c.ID(), err)
 			}