Skip to content

Commit

Permalink
remove contrib/gate
Browse files Browse the repository at this point in the history
Remove references on contrib/gate.  The gating image is currently not
maintained and was replaced in the CI rewrite.  We can disable builds
in Quay once the change is merged.

Note that running `make validate` in a container is still desired.
A similar approach may be re-added in the future.

Signed-off-by: Valentin Rothberg <[email protected]>
  • Loading branch information
vrothberg committed Nov 17, 2020
1 parent 42ec4cf commit c2c7dd8
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 82 deletions.
11 changes: 1 addition & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -286,16 +286,7 @@ commit automatically with `git commit -s`.

### Go Format and lint

All code changes must pass ``make validate`` and ``make lint``, as
executed in a standard container. The container image for this
purpose is provided at: ``quay.io/libpod/gate:master``. With
other tags available for different branches as needed. These
images are built automatically after merges to the branch.

#### Building the gate container locally

For local use, debugging, or experimentation, the gate image may
be built locally from the repository root, with the command:
All code changes must pass ``make validate`` and ``make lint``.

```
podman build -t gate -f contrib/gate/Dockerfile .
Expand Down
41 changes: 0 additions & 41 deletions contrib/gate/Dockerfile

This file was deleted.

6 changes: 0 additions & 6 deletions contrib/gate/README.md

This file was deleted.

23 changes: 0 additions & 23 deletions contrib/gate/entrypoint.sh

This file was deleted.

4 changes: 2 additions & 2 deletions test/e2e/search_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@ registries = ['{{.Host}}:{{.Port}}']`
})

It("podman search single registry flag", func() {
search := podmanTest.Podman([]string{"search", "quay.io/libpod/gate:latest"})
search := podmanTest.Podman([]string{"search", "quay.io/skopeo/stable:latest"})
search.WaitWithDefaultTimeout()
Expect(search.ExitCode()).To(Equal(0))
Expect(search.LineInOutputContains("quay.io/libpod/gate")).To(BeTrue())
Expect(search.LineInOutputContains("quay.io/skopeo/stable")).To(BeTrue())
})

It("podman search image with description", func() {
Expand Down

0 comments on commit c2c7dd8

Please sign in to comment.