Merge pull request #9524 from riyad/apiv3-print-tags-when-building

[Compat API] Also print successfully tagging images in /build endpoint
containers · Mar 11, 2021 · 8d33bfa · 8d33bfa
2 parents e2d35e5 + ba319e3
commit 8d33bfa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/pkg/api/handlers/compat/images_build.go b/pkg/api/handlers/compat/images_build.go
@@ -445,6 +445,13 @@ loop:
 						logrus.Warnf("Failed to json encode error %v", err)
 					}
 					flush()
+					for _, tag := range query.Tag {
+						m.Stream = fmt.Sprintf("Successfully tagged %s\n", tag)
+						if err := enc.Encode(m); err != nil {
+							logrus.Warnf("Failed to json encode error %v", err)
+						}
+						flush()
+					}
 				}
 			}
 			break loop

diff --git a/pkg/api/server/register_images.go b/pkg/api/server/register_images.go
@@ -652,6 +652,7 @@ func (s *APIServer) registerImagesHandlers(r *mux.Router) error {
 	//           example: |
 	//             (build details...)
 	//             Successfully built 8ba084515c724cbf90d447a63600c0a6
+	//             Successfully tagged your_image:latest
 	//   400:
 	//     $ref: "#/responses/BadParamError"
 	//   500:
@@ -1485,7 +1486,6 @@ func (s *APIServer) registerImagesHandlers(r *mux.Router) error {
 	//           description: output from build process
 	//           example: |
 	//             (build details...)
-	//             Successfully built 8ba084515c724cbf90d447a63600c0a6
 	//   400:
 	//     $ref: "#/responses/BadParamError"
 	//   500: