Skip to content

Commit

Permalink
test/e2e: do not try to use docker as rootless
Browse files Browse the repository at this point in the history
Running these locally always created a popup to ask me for my password
as I am in the wheel group.
I would also argue that such a test should not be run on any local
system ever even as root. First docker could be a symlink to podman so
the check if the image is there would fail. Second starting the docker
deamon in a podman test suite just feels very unexpected.

Signed-off-by: Paul Holzinger <[email protected]>
  • Loading branch information
Luap99 committed Apr 13, 2023
1 parent eabb1ed commit 8331cd2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/e2e/push_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,7 @@ var _ = Describe("Podman push", func() {

It("podman push to docker daemon", func() {
SkipIfRemote("Remote push does not support docker-daemon transport")
SkipIfRootless("rootless user has no permission to use default docker.sock")
setup := SystemExec("bash", []string{"-c", "systemctl status docker 2>&1"})

if setup.LineInOutputContains("Active: inactive") {
Expand Down

0 comments on commit 8331cd2

Please sign in to comment.