Skip to content

Commit

Permalink
Merge pull request #14258 from mheon/no_hard_error_on_exec_cleanup
Browse files Browse the repository at this point in the history
Make errors on removing exec sessions nonfatal
  • Loading branch information
openshift-merge-robot authored May 17, 2022
2 parents e28d46b + dc435ec commit 4a78992
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion libpod/runtime_ctr.go
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,11 @@ func (r *Runtime) removeContainer(ctx context.Context, c *Container, force, remo
// after setting the state to ContainerStateRemoving will prevent that the container is
// restarted
if err := c.removeAllExecSessions(); err != nil {
return err
if cleanupErr == nil {
cleanupErr = err
} else {
logrus.Errorf("Remove exec sessions: %v", err)
}
}

// Stop the container's storage
Expand Down

0 comments on commit 4a78992

Please sign in to comment.