auto update: return restart error

Return the error when restarting the unit failed during an update. The task is correctly marked to have failed but we really need to return the error to the user. [NO NEW TESTS NEEDED] - The flakes in #17607 will reveal errors. Signed-off-by: Valentin Rothberg <[email protected]>
containers · Mar 15, 2023 · 3c51b61 · 3c51b61
1 parent 68bf497
commit 3c51b61
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/autoupdate/autoupdate.go b/pkg/autoupdate/autoupdate.go
@@ -203,6 +203,9 @@ func (u *updater) updateUnit(ctx context.Context, unit string, tasks []*task) []
 
 	// Jump to the next unit on successful update or if rollbacks are disabled.
 	if updateError == nil || !u.options.Rollback {
+		if updateError != nil {
+			errors = append(errors, fmt.Errorf("restarting unit %s during update: %w", unit, updateError))
+		}
 		return errors
 	}