fix race where podman events exits to early

In order to display all events we have to read until the event channel is closed. Signed-off-by: Paul Holzinger <[email protected]>
containers · Sep 12, 2022 · 2ae4ce7 · 2ae4ce7
1 parent b3212a6
commit 2ae4ce7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/cmd/podman/system/events.go b/cmd/podman/system/events.go
@@ -101,12 +101,12 @@ func eventsCmd(cmd *cobra.Command, _ []string) error {
 
 	for {
 		select {
-		case err := <-errChannel:
-			return err
-		case event := <-eventChannel:
+		case event, ok := <-eventChannel:
+			if !ok {
+				// channel was closed we can exit
+				return nil
+			}
 			switch {
-			case event == nil:
-				// no-op
 			case doJSON:
 				jsonStr, err := event.ToJSONString()
 				if err != nil {
@@ -121,6 +121,12 @@ func eventsCmd(cmd *cobra.Command, _ []string) error {
 			default:
 				fmt.Println(event.ToHumanReadable(!noTrunc))
 			}
+		case err := <-errChannel:
+			// only exit in case of an error,
+			// otherwise keep reading events until the event channel is closed
+			if err != nil {
+				return err
+			}
 		}
 	}
 }
diff --git a/test/system/090-events.bats b/test/system/090-events.bats
@@ -74,6 +74,7 @@ load helpers
 .*image tag $imageID $tag
 .*image untag $imageID $tag:latest
 .*image tag $imageID $tag
+.*image untag $imageID $IMAGE
 .*image untag $imageID $tag:latest
 .*image remove $imageID $imageID" \
        "podman events"