Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman4: network-usage blog update install instructions #509

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Mar 14, 2022

The podman package will not install netavark when CNI is already
installed.

Ref: containers/podman#11719 (comment)

@Luap99
Copy link
Member Author

Luap99 commented Mar 14, 2022

@lsm5 PTAL

@rhatdan
Copy link
Member

rhatdan commented Mar 15, 2022

LGTM

@lsm5
Copy link
Member

lsm5 commented Mar 15, 2022

netavark is a Recommends on containers-common, so afaict a containers-common upgrade should pull in netavark unless the env has been set to not install recommended packages. Let me verify this and get back.

@Luap99
Copy link
Member Author

Luap99 commented Mar 15, 2022

@lsm5 The problem is not that aardvark is not pulled in, the thing is that netvark is not installed when you update because containernetworking-plugins is already present.

@lsm5
Copy link
Member

lsm5 commented Mar 15, 2022

@lsm5 The problem is not that aardvark is not pulled in, the thing is that netvark is not installed when you update because containernetworking-plugins is already present.

Right, I'm not talking about aardvark either. What I meant was podman4 upgrade should trigger a containers-common upgrade which should pull in netavark, unless they have set Recommends to not be installed by default. Regardless, the explicit installation step doesn't hurt.

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsm5
Copy link
Member

lsm5 commented Mar 15, 2022

@TomSweeneyRedHat PTAL

@Luap99
Copy link
Member Author

Luap99 commented Mar 15, 2022

Ah I see now. I guess you are right and the user didn't had the recommends installed.

@@ -36,5 +36,7 @@ Add the podman4 test COPR to your system
If you have never installed Podman, replace `upgrade` with `install` in the following command.
> $ sudo dnf upgrade podman

If you find bugs, please report them to our [github issues page](https://github.com/containers/podman/issues).
If podman was upgraded, you have to install netavark explicitly otherwise the package will keep using CNI and does not install netavark.
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If podman was upgraded, you have to install netavark explicitly otherwise the package will keep using CNI and does not install netavark.
If Podman was upgraded, you have to install netavark explicitly. Otherwise, the Podman package will continue to use CNI.

The podman package will not install netavark when CNI is already
installed.

Ref: containers/podman#11719 (comment)

Signed-off-by: Paul Holzinger <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM, thx @Luap99 and @lsm5

@TomSweeneyRedHat TomSweeneyRedHat merged commit c8f9e1f into containers:main Mar 15, 2022
@Luap99 Luap99 deleted the network-update branch March 15, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants