Streaming support for PodsManager.stats API #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazCrimson
added a commit
to nicolargo/glances
that referenced
this pull request
May 13, 2023
fix #2390 note: tmp fix Proper sol - containers/podman-py#266
|
@RazCrimson I believe tests should pass now once you rebase |
Signed-off-by: Bharath Vignesh J K <[email protected]>
Signed-off-by: Bharath Vignesh J K <[email protected]>
fix: one bad test for PodManager.stats Signed-off-by: Bharath Vignesh J K <[email protected]>
|
@umohnani8 |
lsm5
approved these changes
May 31, 2023
There was a problem hiding this comment.
LGTM in my limited capacity, I'll defer to @umohnani8 and @rhatdan
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, RazCrimson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman API supports streaming Pod stats, but podman-py does not support that as of now.
This PR aims to add support for that.