Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 4.4.0 #235

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Bump version to 4.4.0 #235

merged 1 commit into from
Feb 8, 2023

Conversation

umohnani8
Copy link
Member

Bump the podman-py version to 4.4.0 to be in lockstep with podman versions.

Signed-off-by: Urvashi Mohnani [email protected]

@openshift-ci openshift-ci bot added the approved label Feb 6, 2023
@umohnani8
Copy link
Member Author

@rhatdan @lsm5 PTAL

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2023

I had opened #229

But this one cought a different version that I had missed.

LGTM, but I think we need to wait until podman 4.4 becomes available from Fedora.

@lsm5
Copy link
Member

lsm5 commented Feb 7, 2023

@cevich RE: #229 (comment) v4.4.0 should already be in updates-testing. Let me know if you can't find it in the repos.

lsm5
lsm5 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

looks like tests are not happy though.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich
Copy link
Member

cevich commented Feb 7, 2023

Let me know if you can't find it in the repos.

Just looked, found this repo. uses a special podman-py image that doesn't use updates-testing 😢 I've opened up a build PR to fix that: containers/automation_images#253

@cevich cevich mentioned this pull request Feb 7, 2023
Merged
@umohnani8
Copy link
Member Author

Waiting for #236, tests will pass once that merged

@umohnani8
Bump version to 4.4.0
8f6b649 
Bump the podman-py version to 4.4.0 to be in lockstep
with podman versions.

Signed-off-by: Urvashi Mohnani <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Feb 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

New changes are detected. LGTM label has been removed.

@jwhonce
Copy link
Member

jwhonce commented Feb 8, 2023

LGTM

@umohnani8
Copy link
Member Author

tests are green, @rhatdan @lsm5 PTAL

@rhatdan
Copy link
Member

rhatdan commented Feb 8, 2023

LGTM

@rhatdan rhatdan merged commit fcca681 into containers:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsm5 lsm5 lsm5 approved these changes

Assignees

@lsm5 lsm5

Labels
approved do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@umohnani8 @rhatdan @lsm5 @cevich @jwhonce