-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix portmapping in container creation #110
Conversation
Fix typos for 'portmapping', align types with documentation, change way it's parsed.
/recheck |
failure looks unrelated, will need to investigate that |
I think containers/podman@a9cb824981 broke the image test because it uses ".containerfile." for the 'dockerfile' parameter which wouldn't be valid json (if i'm reading the patch correctly). @rhatdan would you be able to confirm my theory related to tthe current test failure being reported
|
/retest |
/test all |
@mwhahaha: No presubmit jobs available for containers/podman-py@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwhahaha, sshnaidm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix typos for 'portmapping', align types with documentation,
change way it's parsed.