Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix portmapping in container creation #110

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

sshnaidm
Copy link
Member

@sshnaidm sshnaidm commented Jun 9, 2021

Fix typos for 'portmapping', align types with documentation,
change way it's parsed.

Fix typos for 'portmapping', align types with documentation,
change way it's parsed.
@sshnaidm
Copy link
Member Author

sshnaidm commented Jun 9, 2021

/recheck

@mwhahaha
Copy link
Contributor

mwhahaha commented Jun 9, 2021

failure looks unrelated, will need to investigate that

@mwhahaha
Copy link
Contributor

mwhahaha commented Jun 9, 2021

I think containers/podman@a9cb824981 broke the image test because it uses ".containerfile." for the 'dockerfile' parameter which wouldn't be valid json (if i'm reading the patch correctly).

@rhatdan would you be able to confirm my theory related to tthe current test failure being reported

======================================================================
ERROR: test_build (integration.test_images.ImagesIntegrationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/go/src/github.com/containers/podman-py/podman/tests/integration/test_images.py", line 124, in test_build
    image, stream = self.client.images.build(fileobj=buffer)
  File "/var/tmp/go/src/github.com/containers/podman-py/podman/domain/images_build.py", line 117, in build
    response.raise_for_status(not_found=ImageNotFound)
  File "/var/tmp/go/src/github.com/containers/podman-py/podman/api/client.py", line 65, in raise_for_status
    raise APIError(cause, response=self._response, explanation=message)
podman.errors.exceptions.APIError: 400 Client Error: Bad Request (failed to parse query parameter 'dockerfile': ".containerfile.7b009fd145dab2008d411bd3f4f3ef34cdd67b42": invalid character '.' looking for beginning of value)

@mwhahaha
Copy link
Contributor

/retest

@mwhahaha
Copy link
Contributor

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

@mwhahaha: No presubmit jobs available for containers/podman-py@main

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sshnaidm
Copy link
Member Author

@mwhahaha: No presubmit jobs available for containers/podman-py@main

Probably need to redefine them from "master" to "main", @jwhonce ?

@mwhahaha
Copy link
Contributor

/lgtm

@mwhahaha
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwhahaha, sshnaidm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mwhahaha mwhahaha merged commit aee0113 into containers:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants