feat: add optional language and frameworks fields to recipes #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Martin <[email protected]>
feloy
force-pushed
the
feat-1693/filter-recipes
branch
from
c51c8a0 to
0515c48
Compare
|
Yeah, I agree that the language could have multiple values. It's highly possible that a recipe might bridge different tools and possibly multiple microservices written with different languages. |
axel7083
reviewed
Jan 2, 2025
| @@ -57,4 +57,6 @@ export interface Recipe { | |||
| * server the recipe requires | |||
| */ | |||
| backend?: string; | |||
| language?: string; | |||
There was a problem hiding this comment.
A recipe might be backend / frontend so rust in backend and js in frontend, might be a good idea to have it as an array
Signed-off-by: Philippe Martin <[email protected]>
feloy
force-pushed
the
feat-1693/filter-recipes
branch
from
c5b7e54 to
18a7465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Martin [email protected]
What does this PR do?
Add optional language and frameworks fields to recipes.
I don't know if we want to increase the catalog version number when adding optional fields. @axel7083 @jeffmaury WDYT?
Screenshot / video of UI
What issues does this PR fix or reference?
Related to #1693
How to test this PR?