-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GPUManager): check nvidia container toolkit capabilities #1825
base: main
Are you sure you want to change the base?
feat(GPUManager): check nvidia container toolkit capabilities #1825
Conversation
Signed-off-by: axel7083 <[email protected]>
I dont have a NVIDIA GPU 😢 to test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux code seems to be based on local podman. Is there a way to check ? What is user is using Podman machine ?
|
||
// check nvidia-ctk version | ||
const { version } = await this.getNvidiaContainerToolKitVersion(connection); | ||
console.log('nvidia-ctk version', version); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, in a follow-up PR I want to use telemetry, but I want to be a separate issue as discussion will probably happen :)
@jeffmaury if the |
Moving to draft |
What does this PR do?
Add some utility function to the
GPUManager
to check ifnvidia-ctk
is installed on the machine or native host (linux) for nvidia cards.Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #1824
Requied for #1591
Part of #1708
How to test this PR?
Manually
You can check manually by adding the following code to the studio.ts