Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support task redirection #1745

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Adding the support of tasks action (navigation) in AI Lab

Screenshot / video of UI

Screencast.from.2024-09-18.17-34-25.mp4

What issues does this PR fix or reference?

Fixes #1742

⚠️ Creating an inference server do not create a task (need to create an issue)

How to test this PR?

  • unit tests has been added ✔️
  1. start AI Lab
  2. Go to recipe
  3. Start a recipe
  4. Leave AI Lab
  5. Open Task Manager
  6. Click on View for the recipe pulling task

@axel7083 axel7083 requested review from benoitf, jeffmaury and a team as code owners September 18, 2024 16:13
@axel7083 axel7083 requested review from dgolovin and cdrage September 18, 2024 16:13
@gastoner
Copy link
Contributor

Screen.Recording.2024-09-19.072843.mp4

When downloading multiple models, each for a different recipe, it will show only the first "tasks model" clicked.

@axel7083
Copy link
Contributor Author

When downloading multiple models, each for a different recipe, it will show only the first "tasks model" clicked.

Oh, I see, we can see the task page is updated, but apparently the model in the Select is not updated.

image

image

I will take a look, nice catch

@benoitf
Copy link
Collaborator

benoitf commented Sep 25, 2024

converting to draft for now, as I always see a reminder that I need to review this PR and then open it and then say "ah yes we're missing another fix first"

@axel7083 axel7083 force-pushed the feature/support-task-redirect branch from 74f6ff1 to ff91c9e Compare September 27, 2024 12:06
@axel7083
Copy link
Contributor Author

@gastoner the problem reported is fixed!

@axel7083 axel7083 marked this pull request as ready for review September 27, 2024 12:06
@gastoner
Copy link
Contributor

Redirection to task works well, just I think that the issue is still present

Screen.Recording.2024-09-27.150126.mp4

I think I have current version
image

@axel7083
Copy link
Contributor Author

axel7083 commented Sep 27, 2024

I think I have current version

Did you rebuild the extension ? 🤔

@gastoner
Copy link
Contributor

Yes I've run pnpm install ; pnpm build ; cd ../podman-desktop ; pnpm watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend

@axel7083
Copy link
Contributor Author

Yes I've run pnpm install ; pnpm build ; cd ../podman-desktop ; pnpm watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend

I am perplex @gastoner as I can't reproduce the problem now... 🤔 which os are you on ?

better-tasks-redirection.mp4

@axel7083 axel7083 force-pushed the feature/support-task-redirect branch from ff91c9e to c20d6f3 Compare September 30, 2024 10:55
Copy link
Contributor

@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've had some problem with the branch, cloned again and works as expected.
Great job!

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axel7083 axel7083 merged commit 4d420cb into containers:main Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Lab Tasks should use Podman Desktop navigation route
4 participants