Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display error message from chat conversation #1341

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Jul 5, 2024

What does this PR do?

This PR adds capabilities to display error messages during a chat. So far we just printed the errors in the console, but they are useful to guide the user.

I extended the messages that a conversation includes. So far, we just had ChatMessages, but we could also have ErrorMessages. The only thing i'm not sure about is how to display them, so i chose to use what we have now (just show the newest error message if it's the last message of the conversation), but it could be very easy to display them as part of the conversation so when you scroll up you can see the error you received for an old input. Waiting to hear your preference.

Screenshot / video of UI

image

What issues does this PR fix or reference?

it resolves #1083 and #1021

How to test this PR?

  1. open the playground
  2. add a very long text ( > 2k chars), it should error (i used mistral model)

@lstocchi lstocchi requested review from benoitf, jeffmaury and a team as code owners July 5, 2024 12:46
Signed-off-by: lstocchi <[email protected]>
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a unit test needs to be fixed

Signed-off-by: lstocchi <[email protected]>
@lstocchi lstocchi requested a review from jeffmaury July 9, 2024 08:02
@lstocchi
Copy link
Contributor Author

lstocchi commented Jul 9, 2024

@jeffmaury are you good with this?

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit 873bb7a into containers:main Jul 10, 2024
4 checks passed
@lstocchi lstocchi deleted the i1083 branch July 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After 10-20 questions the chatbot app is no longer working
3 participants