feat: prevent user from deleting model when inUse #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstocchi
approved these changes
Jul 3, 2024
Since we will be using |
feloy
reviewed
Jul 3, 2024
axel7083
commented
Jul 3, 2024
axel7083
commented
Jul 3, 2024
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
axel7083
force-pushed
the
feature/prevent-model-deletion-in-use
branch
from
4bb1dae to
09a3a28
Compare
axel7083
commented
Jul 3, 2024
Signed-off-by: axel7083 <[email protected]>
axel7083
commented
Jul 3, 2024
Signed-off-by: axel7083 <[email protected]>
feloy
approved these changes
Jul 3, 2024
axel7083
commented
Jul 3, 2024
packages/frontend/src/lib/table/model/ModelColumnAction.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: axel7083 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve the Models page by changing the StatusIcon depending on the model usage.
When the model is used by an inference server, it is marked as
USED. A model which is downloaded has a titleDOWNLOADED.The delete button is also disabled when model is inUse
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #791
How to test this PR?