Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dispose webview panel #1172

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Jun 6, 2024

What does this PR do?

#1167 introduced a regression, it removed (by accident) to add the webview panel created to the subscriptions that must be disposed when the extension is stopped.

Screenshot / video of UI

What issues does this PR fix or reference?

How to test this PR?

@axel7083 axel7083 requested review from benoitf and a team as code owners June 6, 2024 13:41
@axel7083 axel7083 requested review from feloy and lstocchi June 6, 2024 13:41
@axel7083 axel7083 enabled auto-merge (squash) June 6, 2024 13:48
@axel7083 axel7083 merged commit 02a5039 into containers:main Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants