Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent using keyboard in plyaground while request is ongoing #1170

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jeffmaury
Copy link
Contributor

Fixes #1087

What does this PR do?

Prevent using keyboard while there is a request being processed

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

#1087

How to test this PR?

Use the playground

@jeffmaury jeffmaury requested review from benoitf and a team as code owners June 6, 2024 13:08
@jeffmaury jeffmaury requested a review from lstocchi June 6, 2024 13:08
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only doubt is, should we change the placeholder color when it is disabled? To make it even more clear?

@jeffmaury jeffmaury merged commit 39b29a1 into containers:main Jun 21, 2024
4 checks passed
@jeffmaury jeffmaury deleted the GH-1087 branch June 21, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playground: Enter key is still enabled when "Send" button is disabled
3 participants