Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ApplicationManager): remove unused interfaces #1114

Merged
merged 2 commits into from
May 27, 2024
Merged

refactor(ApplicationManager): remove unused interfaces #1114

merged 2 commits into from
May 27, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented May 22, 2024 •
edited
Loading

What does this PR do?

  • The custom interface ContainerAttachedInfo is replaced with PodContainerInfo (from api)
  • The custom interface ApplicationPodInfo is replaced with PodInfo (from api)
  • Renaming runApplication to initApplication to better match what it is doing (see code comment added)
  • createAndAddContainersToPod is renamed to createContainerAndAttachToPod

Screenshot / video of UI

What issues does this PR fix or reference?

Work is required for #691

How to test this PR?

  • unit tests has been provided

You can check recipes are working as expected

  • Start recipe
  • Stop recipe
  • Restart recipe

@axel7083 axel7083 requested review from benoitf and a team as code owners May 22, 2024 13:00
@axel7083 axel7083 requested a review from jeffmaury May 22, 2024 13:00
@axel7083 axel7083 requested review from feloy and lstocchi May 22, 2024 14:14
@axel7083 axel7083 self-assigned this May 22, 2024
lstocchi
lstocchi approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axel7083 axel7083 merged commit 734d11a into containers:main May 27, 2024
4 checks passed
@axel7083 axel7083 mentioned this pull request May 27, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstocchi lstocchi lstocchi approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

@jeffmaury jeffmaury Awaiting requested review from jeffmaury jeffmaury was automatically assigned from containers/podman-desktop-extension-ai-lab-reviewers

@feloy feloy Awaiting requested review from feloy

Assignees

@axel7083 axel7083

Labels
area/ai-apps area/recipe technical-debt
Projects
Podman Desktop Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axel7083 @lstocchi