Remove named volumes during "down -v"

[lcarva]

Fixes #105

Signed-off-by: Luiz Carvalho [email protected]

[lcarva]

@muayyad-alsadi any chance you could have a look on this one? Thanks in advance!

[muayyad-alsadi]

I'm very sorry for taking so long. I've moved to a new house and I feel I must review this one because I don't want to remove volumes by mistake.

BTW we can remove volumes using labels.

[lcarva]

I'm very sorry for taking so long. I've moved to a new house and I feel I must review this one because I don't want to remove volumes by mistake.

BTW we can remove volumes using labels.

No worries! I hope the new house is wonderful.

I've tried to use a single podman command to remove all the volumes based on labels, but was not able to do so. I've opted to listing all the volumes and inspecting the labels on each one. I'm happy to hear an alternative approach.

I also tried using podman volume ls which has a filter option. However, this seems to only allow filtering by label name, and not its value.

[muayyad-alsadi]

No worries! I hope the new house is wonderful.

in deed, it's a nice villa.

I've tried to use a single podman command to remove all the volumes based on labels,

we set a label io.podman.compose.project with value equal to project name
the single command is

podman volume list --format '{{.Name}}' -f 'label=io.podman.compose.project=HERE' | xargs -r podman volume rm

I had the following todo comment in the source code

    # TODO: might move to using "volume list"
    # podman volume list --format '{{.Name}}\t{{.MountPoint}}' -f 'label=io.podman.compose.project=HERE'
    try: out = compose.podman.output(["volume", "inspect", vol_name]).decode('utf-8')
    except subprocess.CalledProcessError:
        compose.podman.output(["volume", "create", "--label", "io.podman.compose.project={}".format(proj_name), vol_name])
        out = compose.podman.output(["volume", "inspect", vol_name]).decode('utf-8')

[lcarva]

No worries! I hope the new house is wonderful.

in deed, it's a nice villa.

I've tried to use a single podman command to remove all the volumes based on labels,

we set a label io.podman.compose.project with value equal to project name
the single command is

podman volume list --format '{{.Name}}' -f 'label=io.podman.compose.project=HERE' | xargs -r podman volume rm

I had the following todo comment in the source code

    # TODO: might move to using "volume list"
    # podman volume list --format '{{.Name}}\t{{.MountPoint}}' -f 'label=io.podman.compose.project=HERE'
    try: out = compose.podman.output(["volume", "inspect", vol_name]).decode('utf-8')
    except subprocess.CalledProcessError:
        compose.podman.output(["volume", "create", "--label", "io.podman.compose.project={}".format(proj_name), vol_name])
        out = compose.podman.output(["volume", "inspect", vol_name]).decode('utf-8')

Yes, I saw that. That syntax doesn't work for me with podman 2.1.1.

[markandrewj]

Any word on this? I notice the discussion around it stopped in 2020.

[sferich888]

@lcarva can we fix the merge conflicts?

[lcarva]

@lcarva can we fix the merge conflicts?

Done!

[muayyad-alsadi]

I'll invite you to jump to 1.x branch and start playing with it. I'll port this fix to it.

0.1 for legacy versions of podman, 1.x for modern versions (CNI network, no need for mapping and workarounds).

by the end of this weekend I hope I can update the documentation.

[muayyad-alsadi]

@lcarva why you used

podman volume inspect --all

instead of

podman volume ls --noheading -f label=io.podman.compose.project=simple --format '{{.Name}}'

what are the podman versions that don't support the latter?

[lcarva]

@lcarva why you used

podman volume inspect --all

instead of

podman volume ls --noheading -f label=io.podman.compose.project=simple --format '{{.Name}}'

what are the podman versions that don't support the latter?

Podman 2.1.1 is what I had used, but that was over a year ago.

The -f filtering was just not working at all. IIRC, it was not checking the value of the label, just its name. It would return any volume that had the label io.podman.compose.project regardless of its value.

I just tried this again with Podman 3.4.4 and it appears to have been fixed. containers/podman#8345 appears to be the fix.

+1 to switching to using that now, but it may not work for older versions of podman.

[lcarva]

+1 to switching to using that now, but it may not work for older versions of podman.

PR submitted: #402

[muayyad-alsadi]

podman-compose version 1.x is for podman>=3.1.0
we are safe to go.