-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create non-existing binding volumes #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Them user could mount in a non permitted directory and cause a issue
If that's the case, do we want the exception to bubble up? Or silently fail? Bubbling up the error might give the user a better idea of what the problem actually is. |
Errors like it should be catched and printed to user understand what is wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right! This solve the issue!
Ideally, this would be done by podman, but in the mean time do it in podman-compose for a better user experience. Fixes containers#185 Signed-off-by: Luiz Carvalho <[email protected]>
Signed-off-by: Luiz Carvalho <[email protected]>
Updated the PR to only perform this action if in compatibility mode as suggested in #185. |
I see that the compatibility mode is not in the principal ( |
Ideally, this would be done by podman, but in the mean time do it in
podman-compose for a better user experience.
Fixes #185
Signed-off-by: Luiz Carvalho [email protected]