Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create non-existing binding volumes #194

Closed
wants to merge 2 commits into from

Conversation

lcarva
Copy link
Contributor

@lcarva lcarva commented Jun 12, 2020

Ideally, this would be done by podman, but in the mean time do it in
podman-compose for a better user experience.

Fixes #185

Signed-off-by: Luiz Carvalho [email protected]

Copy link

@flaviotux flaviotux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Them user could mount in a non permitted directory and cause a issue

podman_compose.py Outdated Show resolved Hide resolved
@lcarva
Copy link
Contributor Author

lcarva commented Jun 23, 2020

Them user could mount in a non permitted directory and cause a issue

If that's the case, do we want the exception to bubble up? Or silently fail? Bubbling up the error might give the user a better idea of what the problem actually is.

@flaviotux
Copy link

Errors like it should be catched and printed to user understand what is wrong.

Copy link

@flaviotux flaviotux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right! This solve the issue!

Ideally, this would be done by podman, but in the mean time do it in
podman-compose for a better user experience.

Fixes containers#185

Signed-off-by: Luiz Carvalho <[email protected]>
Signed-off-by: Luiz Carvalho <[email protected]>
@lcarva
Copy link
Contributor Author

lcarva commented Oct 13, 2020

Updated the PR to only perform this action if in compatibility mode as suggested in #185.

@muayyad-alsadi muayyad-alsadi deleted the branch containers:devel December 9, 2021 13:33
@amn
Copy link

amn commented Sep 25, 2023

I see that the compatibility mode is not in the principal (devel) branch -- issue #185 was closed but the commit did not introduce the compatibility mode, was the idea scrapped? This PR proposes a commit adding the mode but it's not merged. Sorry for sharing my confusion, but I tripped over the "let's create empty directories for volumes for which source files are missing" behaviour today, as I haven't used Docker and am not used to its behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create non-existing bind volumes
4 participants