Absolute host paths #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add custom (de)serializer for mount options. - Simplify conversion of compose service volumes.
Also refactored compose service volume conversion.
- Add `HostPaths` trait. - Move `cli::kube::File` to `quadlet::Kube::YamlFile`. - Add `podlet --absolute-host-paths` option. - Resolve relative host paths (e.g. volume source) to absolute paths.
|
@rugk could you test this out and see if it meets your expectations? |
|
I'm going to merge this tomorrow unless there are any objections. That way I can work on getting a release out this weekend. |
|
Awesome! Thanks in any case. Unfortunately don't have resources to test this now, but I assume it works great. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52.
The main thing this PR does is add the
podlet --absolute-host-pathsoption which converts relative host paths (e.g. volume source) to absolute paths. Getting there required a fair amount of yak shaving in the form of fully parsing (and reassembling on output) various podman options. The biggest of which was the mount options for which I implemented another customSerializerandDeserializer.