feat: set compatibility with --podman-version
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting a lower podman version will downgrade the quadlet's compatibility. Will return an error if an incompatible quadlet option is used. Implemented as an in-place, one-way transformation of `quadlet::File` and its parts. That way, there is less complexity than dealing with multiple versions of each quadlet resource type. `--podman-version` has aliases `--compatibility` and `--compat`. Also enabled `wrap_help` feature of clap. Closes: #45
Serializing maps to args is not needed. The removal allows for eliminating a box allocation for each flag and making the arg serializer simpler and more similar to the quadlet serializer. Also removed the `skip_serializing_if`s from `PodmanArgs` structs (since serializing empty `Vec`s or `Option`s no longer incurs an allocation) to reduce code generation and if checks.
|
@cyqsimon, can you test this out and see if it fits with what you wanted? |
|
I tested on a few different compose files and it's looking great. The code looks pretty much like what I imagined too. I have no complaints whatsoever. Thank you so much for swiftly taking on the feature request! |
|
Oh yes. I noticed that you probably want to update README, in particular the FEATURES and CAUTIONS sections. |
|
Will do when I'm getting ready to release the next podlet version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
Setting a lower podman version will downgrade generated quadlets compatibility. Will return an error if an incompatible quadlet option is used.
Implemented as an in-place, one-way transformation of
quadlet::Fileand its parts. That way, there is less complexity than dealing with multiple versions of each quadlet resource type.--podman-versionhas aliases--compatibilityand--compat.