Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compose): network_mode accept all podman values #42

Merged
merged 1 commit into from
Dec 24, 2023
Merged

fix(compose): network_mode accept all podman values #42

merged 1 commit into from
Dec 24, 2023

Conversation

k9withabone
Copy link
Member

Closes #38

  • Support all podman run --network values for service network_mode
  • Improve error message for unsupported values, link to the podman docs

The error message for network_mode values of service now looks like:

Error: 
   0: Could not parse service `test` as a valid podman command
   1: network_mode `service:` is not supported by podman

Location:
   src/cli/container/quadlet.rs:807

Suggestion: try using the `container:` network_mode instead
Suggestion: see the --network section of the podman-run(1) documentation for supported values: https://docs.podman.io/en/stable/markdown/podman-run.1.html#network-mode-net

@k9withabone
fix(compose): network_mode accept all podman values
561bd22 
- Support all `podman run --network` values for service `network_mode`
- Improve error message for unsupported values, link to the podman docs

Fixes: #38
@k9withabone k9withabone added this to the v0.2.3 milestone Dec 22, 2023
@k9withabone k9withabone linked an issue Dec 22, 2023 that may be closed by this pull request
improve compose network_mode error message #38
Closed
@k9withabone
Copy link
Member Author

@trijpstra-fourlights what do you think?

@trijpstra-fourlights
Copy link

LGTM! 👍 nice work

@k9withabone k9withabone merged commit 6fabdff into main Dec 24, 2023
9 checks passed
@k9withabone k9withabone deleted the network_mode-error-message branch December 24, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trijpstra-fourlights trijpstra-fourlights trijpstra-fourlights approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.

improve compose network_mode error message
2 participants
@k9withabone @trijpstra-fourlights