Podman v4.6.0 / Podlet v0.2.2 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, in `cli::container::quadlet`, refactored `impl From<QuadletOptions> for crate::quadlet::Container` a bit to use `Option::map_or` and added `Notify::is_container()`.
Created a custom serde `Serializer` for serializing into command arguments and added a `Serialize` derive to `cli::container::podman::PodmanArgs`. This replaces the manaul `Display` impl, improving readability and reducing chances for errors.
Bools are now serialized as `--flag` or `--flag=false`.
Made `quadlet::writeln_escape_spaces()` take a generic const parameter for the separator used for joining the words.
Also added doc comments to quadlet fields with first sentence from the quadlet documentation.
Fixes: #32 Also, in joined quadlet values, strings containing any whitespace are now quoted, not just if it conains a space.
…ice fields Fixes: #31
When the command in converted to the `Exec=` quadlet option, it is now properly quoted. When converting to k8s, it is properly split into args. Fixes: #36
This was
linked to
issues
Dec 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28. Fixes #32, #31, #34, and #36.
Displayimpls for quadlet sections and podman args.serdeand customSerializers.