-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @isinyaaa much appreciated !
I'm not a big fan of reformattings, but I'd take it.
Can you kindly clarify/help me better understand the followings:
-
simplify type annotations 1c7f52f
to me that is python 3.10 and up: https://peps.python.org/pep-0604
btw, not sure why mypy is not complaining about this 🤔 -
provider: skip mode-setting before download_blob b95b014
why would I skip mode=w here for file which I want to write, please? 🤔 asking for improving my py knowledge! :D
About the E2E test failure, see below:
I can disable my auto-formatter if you prefer, but having some sort of style guidelines would be helpful for contributions.
when you declare
You don't need it because |
7344458
to
8de9738
Compare
thanks for the clarification @isinyaaa , can you please reword your commits to sign-off for DCO, ...or just squash them if easier to add the required DCO |
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
8de9738
to
168bd5c
Compare
many thanks again, proceeding to merge |
Some improvement suggestions from a quick look around. Tested with existing tests, but I still haven't been able to run e2e.