TODO and relative import cleanup #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
isinyaaa
force-pushed
the
push-nlxwsytwopkq
branch
from
7d126a6
to
4b33231
Compare
isinyaaa
commented
Oct 24, 2024
isinyaaa
commented
Oct 24, 2024
isinyaaa
commented
Oct 24, 2024
Signed-off-by: Isabella do Amaral <[email protected]>
isinyaaa
force-pushed
the
push-nlxwsytwopkq
branch
from
fc66293
to
3f36bd3
Compare
Signed-off-by: Isabella do Amaral <[email protected]>
tarilabs
reviewed
Oct 25, 2024
isinyaaa
commented
Oct 25, 2024
omlmd/listener.py
Outdated
Comment on lines
39
to
40
| def get_digest(self) -> str: | ||
| return self.response.headers["Docker-Content-Digest"] if self.ok else "" |
There was a problem hiding this comment.
I like the idea of a helper to find the digest, but I'm not sure what this should do when the response is not ok.
Also, are we looking at a 200-ish or strictly 200 here?
There was a problem hiding this comment.
- let's return ValueError
- 2xx please
There was a problem hiding this comment.
Oras-Py is already checking that for us before returning on push. As we can see
_check_200_response already performs the checks you specified.
Edit: updated accordingly. Let me know what you think.
isinyaaa
force-pushed
the
push-nlxwsytwopkq
branch
3 times, most recently
from
556d109
to
d902e95
Compare
Signed-off-by: Isabella do Amaral <[email protected]>
isinyaaa
force-pushed
the
push-nlxwsytwopkq
branch
2 times, most recently
from
a8ee5e2
to
aa2331a
Compare
Signed-off-by: Isabella do Amaral <[email protected]>
isinyaaa
force-pushed
the
push-nlxwsytwopkq
branch
from
aa2331a
to
8b82359
Compare
|
thanks a lot @isinyaaa , much appreciated ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.