-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[podresapi 2/3] resmgr,agent: generate topology hints from Pod Resource API. #419
Open
klihub
wants to merge
4
commits into
containers:main
Choose a base branch
from
klihub:devel/hints-from-pod-resource-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
devel/hints-from-pod-resource-api
branch
2 times, most recently
from
December 1, 2024 17:53
5f9f2ea
to
5f1519e
Compare
klihub
changed the title
[Pod Resource API 2/3]: generate topology hints from Pod Resource API.
[podresapi 2/3]: generate topology hints from Pod Resource API.
Dec 1, 2024
/cc @pfl |
klihub
changed the title
[podresapi 2/3]: generate topology hints from Pod Resource API.
[podresapi 2/3] generate topology hints from Pod Resource API.
Dec 2, 2024
kad
reviewed
Dec 2, 2024
kad
reviewed
Dec 2, 2024
klihub
changed the title
[podresapi 2/3] generate topology hints from Pod Resource API.
[podresapi 2/3] resmgr,agent: generate topology hints from Pod Resource API.
Dec 2, 2024
klihub
force-pushed
the
devel/hints-from-pod-resource-api
branch
2 times, most recently
from
December 3, 2024 09:09
a91bbf4
to
f0622a5
Compare
klihub
force-pushed
the
devel/hints-from-pod-resource-api
branch
from
December 3, 2024 15:22
f0622a5
to
dc900fa
Compare
Add configuration for the agent itself. Currently the only control enables access to Node Resource Topology Custom Resources and it is on by default. Update the agent to honor its configuration. Signed-off-by: Krisztian Litkey <[email protected]>
Add support for tapping into the kubelet's pod resource API to query extra information about resources assigned to pods and containers. Use such a new client to expose agent functions for listing and querying pod resources, both synchronously and asynchronously. Signed-off-by: Krisztian Litkey <[email protected]>
Try querying Pod Resource API and generate extra topology hints using container device assignments listed there. Signed-off-by: Krisztian Litkey <[email protected]>
Bind-mount kubelet pod-resources directory read-only to plugin daemonset, to provide access to kubelet pod-resources socket. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/hints-from-pod-resource-api
branch
from
December 3, 2024 15:24
dc900fa
to
c1a1417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series
Pod Resource API queries are triggered asynchronously during pod creation/handling
RunPodSandbox
NRI events. Container creation waits for any pending queries (with a short timeout) then generates extra topology hints if the results contain devices with declared NUMA-locality. The existing device allow-/deny-annotations can be used to explicitly allow or deny topology hints corresponding to Pod Resource API hints.