Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[podresapi 2/3] resmgr,agent: generate topology hints from Pod Resource API. #419

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Dec 1, 2024

This patch series

  • adds support to query the kubelet's Pod Resource API via the agent
  • generates extra topology hints using the Pod Resource API, if it is enabled
  • updates Helm charts to provide access to the kubelet's Pod Resource API socket

Pod Resource API queries are triggered asynchronously during pod creation/handling RunPodSandbox NRI events. Container creation waits for any pending queries (with a short timeout) then generates extra topology hints if the results contain devices with declared NUMA-locality. The existing device allow-/deny-annotations can be used to explicitly allow or deny topology hints corresponding to Pod Resource API hints.

@klihub klihub force-pushed the devel/hints-from-pod-resource-api branch 2 times, most recently from 5f9f2ea to 5f1519e Compare December 1, 2024 17:53
@klihub klihub changed the title [Pod Resource API 2/3]: generate topology hints from Pod Resource API. [podresapi 2/3]: generate topology hints from Pod Resource API. Dec 1, 2024
@klihub
Copy link
Collaborator Author

klihub commented Dec 2, 2024

/cc @pfl

@klihub klihub changed the title [podresapi 2/3]: generate topology hints from Pod Resource API. [podresapi 2/3] generate topology hints from Pod Resource API. Dec 2, 2024
@klihub klihub marked this pull request as draft December 2, 2024 09:42
@klihub klihub marked this pull request as ready for review December 2, 2024 11:48
pkg/agent/agent.go Show resolved Hide resolved
@klihub klihub changed the title [podresapi 2/3] generate topology hints from Pod Resource API. [podresapi 2/3] resmgr,agent: generate topology hints from Pod Resource API. Dec 2, 2024
@klihub klihub force-pushed the devel/hints-from-pod-resource-api branch 2 times, most recently from a91bbf4 to f0622a5 Compare December 3, 2024 09:09
@klihub klihub requested a review from kad December 3, 2024 12:35
@klihub klihub force-pushed the devel/hints-from-pod-resource-api branch from f0622a5 to dc900fa Compare December 3, 2024 15:22
Add configuration for the agent itself. Currently the
only control enables access to Node Resource Topology
Custom Resources and it is on by default. Update the
agent to honor its configuration.

Signed-off-by: Krisztian Litkey <[email protected]>
Add support for tapping into the kubelet's pod resource
API to query extra information about resources assigned
to pods and containers. Use such a new client to expose
agent functions for listing and querying pod resources,
both synchronously and asynchronously.

Signed-off-by: Krisztian Litkey <[email protected]>
Try querying Pod Resource API and generate extra topology
hints using container device assignments listed there.

Signed-off-by: Krisztian Litkey <[email protected]>
Bind-mount kubelet pod-resources directory read-only to plugin
daemonset, to provide access to kubelet pod-resources socket.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub force-pushed the devel/hints-from-pod-resource-api branch from dc900fa to c1a1417 Compare December 3, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants