-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix prun pod with container #4422
Conversation
fix containers#4346 This PR sets c.Force to true if user reply 'y' to system prune confirmation question. Signed-off-by: Qi Wang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: QiWang19 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mheon @TomSweeneyRedHat PTAL. |
This seems VERY dangerous. We're only supposed to be removing unused containers and pods - setting force is directly counter to that. |
I think the original suggestion - removing containers before pods - might be more suitable here. We want to prune unused containers, then prune any pod with no containers but the infra container, then prune unused images. |
(Would need to make sure we don't accidentally prune infra containers when we prune the containers, though) |
The use of |
We don't prompt, the way that Docker does, So we should just add this as a no-op. If you run docker image prune So Just add the flag so that we can work with existing scripts. |
fix #4346
This PR sets c.Force to true if user reply 'y' to system prune confirmation question.
Signed-off-by: Qi Wang [email protected]