inspect: rename ImageID go field to Image #4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
LGTM |
|
Rerunning tests. |
|
Found some cycles to look into the test failures which are fixed now. |
|
/lgtm |
|
Looks like the gating job is stuck. |
The json field is called `Image` while the go field is called `ImageID`, tricking users into filtering for `Image` which ultimately results in an error. Hence, rename the field to `Image` to align json and go. To prevent podman users from regressing, rename `Image` to `ImageID` in the specified filters. Add tests to prevent us from regressing. Note that consumers of the go API that are using `ImageID` are regressing; ultimately we consider it to be a bug fix. Fixes: containers#4193 Signed-off-by: Valentin Rothberg <[email protected]>
|
Repushed to retrigger the blocked gating test. |
|
Needs another lgtm :^) |
|
Suffering from the --rm flakes. Restarted. |
|
@rhatdan @TomSweeneyRedHat mind (re)dropping the final lgtm for merging? |
|
/lgtm |
sebastian-philipp
added a commit
to sebastian-philipp/ceph
that referenced
this pull request
Jan 13, 2020
See containers/podman#4195 Signed-off-by: Sebastian Wagner <[email protected]>
3 tasks
sebastian-philipp
added a commit
to sebastian-philipp/ceph
that referenced
this pull request
Jan 20, 2020
See containers/podman#4195 Signed-off-by: Sebastian Wagner <[email protected]>
sebastian-philipp
added a commit
to sebastian-philipp/ceph
that referenced
this pull request
Jan 21, 2020
See containers/podman#4195 Signed-off-by: Sebastian Wagner <[email protected]>
mgfritch
added a commit
to mgfritch/ceph
that referenced
this pull request
Jan 22, 2020
See containers/podman#4195 Signed-off-by: Michael Fritch <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json field is called
Imagewhile the go field is calledImageID,tricking users into filtering for
Imagewhich ultimately results in anerror. Hence, rename the field to
Imageto align json and go.To prevent podman users from regressing, rename
ImagetoImageIDinthe specified filters. Add tests to prevent us from regressing. Note
that consumers of the go API that are using
ImageIDare regressing;ultimately we consider it to be a bug fix.
Fixes: #4193
Signed-off-by: Valentin Rothberg [email protected]