varlink endpoint for containerstats requires root #3753
Merged
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
baude
force-pushed
the
varlinkrequiresroot
branch
from
1fe7009 to
d6eae67
Compare
mheon
reviewed
Aug 7, 2019
rhatdan
reviewed
Aug 8, 2019
rhatdan
reviewed
Aug 8, 2019
rhatdan
reviewed
Aug 8, 2019
|
Make it work with cgroupsV2 check and then we can merge. |
baude
force-pushed
the
varlinkrequiresroot
branch
2 times, most recently
from
31281f5 to
0710176
Compare
|
merge me |
mheon
reviewed
Aug 11, 2019
|
LGTM after fixing the issue @mheon pointed out |
obtaining containerstats requires the use of cgroups. at present, rootless users do not have privileges to create cgroups. add an error message that catches this for the varlink endpoint and return a proper error. Fixes: containers#3749 Signed-off-by: baude <[email protected]>
|
fixed |
baude
force-pushed
the
varlinkrequiresroot
branch
from
0710176 to
55cc80d
Compare
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obtaining containerstats requires the use of cgroups. at present,
rootless users do not have privileges to create cgroups. add an error
message that catches this for the varlink endpoint and return a proper
error.
Fixes: #3749
Signed-off-by: baude [email protected]