imagefilter dangling handling corrected #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the issue #2884 |
|
LGTM |
|
LGTM, assuming happy tests |
rhatdan
reviewed
Apr 10, 2019
cmd/podman/imagefilters/filters.go
Outdated
| return i.Dangling() | ||
| if danglingImages { | ||
| return i.Dangling() | ||
| } else { |
There was a problem hiding this comment.
No need for the else block. Just return !i.Dangling()
cmd/podman/images.go
Outdated
| @@ -359,6 +360,9 @@ func CreateFilterFuncs(ctx context.Context, r *adapter.LocalRuntime, filters []s | |||
| var filterFuncs []imagefilters.ResultFilter | |||
| for _, filter := range filters { | |||
| splitFilter := strings.Split(filter, "=") | |||
| if len(splitFilter) != 2 { | |||
| return nil, fmt.Errorf("invalid filter syntax %s", filter) | |||
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunalkushwaha, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
imagefilter dangling=<value> shall not be ignored. this PR handles the value and returns images accordingly. Signed-off-by: Kunal Kushwaha <[email protected]>
kunalkushwaha
force-pushed
the
image-dangling-filter-fix
branch
from
b33a48d to
034cc8a
Compare
|
Updated the PR as per review comments. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imagefilter dangling=<value>shall not be ignored.this PR handles the value and returns images accordingly.
Signed-off-by: Kunal Kushwaha [email protected]