rootless: fill in correct storage conf default #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
giuseppe
force-pushed
the
rootless-storage-config
branch
from
ebf06bb to
0042831
Compare
|
Looks like a test isn't buying this change. |
|
LGTM other then the error message. |
giuseppe
force-pushed
the
rootless-storage-config
branch
from
0042831 to
a096360
Compare
When the configuration file is specified, be sure to fill rootless compatible values in the default configuration. Closes: containers#2510 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
rootless-storage-config
branch
from
a096360 to
2ac7991
Compare
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the configuration file is specified, be sure to fill rootless
compatible values in the default configuration.
Closes: #2510
Signed-off-by: Giuseppe Scrivano [email protected]