rootless: force same cwd when re-execing #2393
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
LGTM, thanks for the great fix, @giuseppe! I tested it locally and can confirm it's working now. |
vrothberg
added
the
needs-backport
|
@mheon, we created a new label Edit: it allows browsing (closed) PRs. Once the commits are backported, the label could be removed again. |
|
☔ The latest upstream changes (presumably #2392) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@vrothberg With any luck, we will never do another 1.0.x release (it's getting painfully out of date) - and given the RHEL process, if we do, it should only be customer BZs, so this will almost certainly not make it. Any reason we really need this backported? |
| fprintf (stderr, "cannot chdir: %s\n", strerror (errno)); | ||
| _exit (EXIT_FAILURE); | ||
| } | ||
| free (cwd); |
There was a problem hiding this comment.
Nit, after fixing this up in fuse-overlay. Shouldn't this be cleaned up automatically.
There was a problem hiding this comment.
we could start using auto cleanups, although this doesn't really make any practical difference as we are going to exec
I don't think there's a specific reason unless a customer hits it :^) |
|
I agree, we only back port fixes pointed out by customers. Hopefully everyone using podman and container-tools will ignore the slow moving train. |
|
LGTM, other then the nit. |
|
LGTM once tests go green |
giuseppe
force-pushed
the
reexec-into-same-wd
branch
from
0809a5c to
c38ce06
Compare
|
/retest |
giuseppe
force-pushed
the
reexec-into-same-wd
branch
2 times, most recently
from
cff5439 to
02a40e7
Compare
giuseppe
force-pushed
the
reexec-into-same-wd
branch
6 times, most recently
from
13b1399 to
201225a
Compare
|
/retest |
|
@giuseppe You might be better off rebasing... CI is going a little crazy today |
when joining an existing namespace, we were not maintaining the current working directory, causing commands like export -o to fail when they weren't referring to absolute paths. Closes: containers#2381 Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
reexec-into-same-wd
branch
from
201225a to
7e920e4
Compare
|
tests are green! |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
when joining an existing namespace, we were not maintaining the current working directory, causing commands like export -o to fail when they weren't referring to absolute paths.
Closes: #2381
Signed-off-by: Giuseppe Scrivano [email protected]