Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct module path in (make test-skopeo) #727

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 3, 2019

The current go mod edit c/image=... did not affect the actually used version at all.

The current (go mod edit c/image=...) did not affect the actually
used version at all.

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac
Copy link
Collaborator Author

mtrmac commented Oct 3, 2019

This has extra commits that break ABI to verify that the tests actually detect that; I’ll remove them if the output looks right.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Oct 3, 2019

Looks reasonable:

+ pwd
+ project_path=/gopath/src/github.com/containers/image
+ GO111MODULE=on go list .
+ project_module=github.com/containers/image/v4
+ mktemp -d
+ export GOPATH=/tmp/tmp.r65LKzqzAt
+ skopeo_path=/tmp/tmp.r65LKzqzAt/src/github.com/containers/skopeo
+ git clone -b master https://github.com/containers/skopeo /tmp/tmp.r65LKzqzAt/src/github.com/containers/skopeo
+ cd /tmp/tmp.r65LKzqzAt/src/github.com/containers/skopeo
+ GO111MODULE=on go mod edit -replace github.com/containers/image/v4=/gopath/src/github.com/containers/image
+ make vendor
+ make BUILDTAGS=btrfs_noversion libdm_no_deferred_remove binary-local test-all-local
…
cmd/skopeo/signing.go:53:20: undefined: signature.SignDockerManifest

fails as expected.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Oct 3, 2019

@vrothberg FYI, merging this now without review to minimize the risk of PRs that break Skopeo without us noticing sneaking in.

PTAL to verify I’m not doing something idiotic when you get a chance.

@mtrmac mtrmac merged commit f06ac5b into containers:master Oct 3, 2019
@mtrmac mtrmac deleted the test-skopeo-v4 branch October 3, 2019 23:57
@mtrmac
Copy link
Collaborator Author

mtrmac commented Oct 4, 2019

NOTE: Looking at Travis logs, it does (git fetch $the_pr && git checkout FETCH_HEAD), i.e. this PR only affects other PRs that have been rebased on top. Re-running travis tests that have been branched off earlier won’t work, unless that changes the checkout process.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick 👍 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants