add http response to log #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
reviewed
Sep 24, 2019
QiWang19
force-pushed
the
resplog
branch
4 times, most recently
from
dfffa35 to
cefef03
Compare
mtrmac
reviewed
Sep 26, 2019
mtrmac
reviewed
Sep 27, 2019
fix containers/podman#3884 Add http response message log to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
commented
Oct 1, 2019
| @@ -533,6 +533,8 @@ func (c *dockerClient) getBearerToken(ctx context.Context, challenge challenge, | |||
| defer res.Body.Close() | |||
| switch res.StatusCode { | |||
| case http.StatusUnauthorized: | |||
| err := client.HandleErrorResponse(res) | |||
| logrus.Debugf("Server response when trying to obtain an access token: \n%q", err.Error()) | |||
| return nil, ErrUnauthorizedForCredentials | |||
There was a problem hiding this comment.
what does break API mean?
return nil, errors.Wrapf(err, "Server response when trying to obtain an access token")
There was a problem hiding this comment.
In current version Buildah and Podman can just look at the return code and compare it to ErrUnauthorizedForCredentials
If we wrap the error with the message, then podman and buildah will no longer get ErrUnauthorizedForCredentials back, they would have to take the error returned and change it to
if errors.Cause(err) == ErrUnauthorizedForCredentials
Any time the users of a library have to change their code, then you have broken ABI, if the callers do not have to change their code, then ABI remained the same.
There was a problem hiding this comment.
Ok, Thanks, PTAL #719
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 1, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 1, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 1, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 2, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 2, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 3, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 3, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 4, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 22, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 22, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
QiWang19
added a commit
to QiWang19/image
that referenced
this pull request
Oct 24, 2019
follow containers#709 return and wrap http response message to show server-side error message. Signed-off-by: Qi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix containers/podman#3884
Add http response message log to show server-side error message.
Signed-off-by: Qi Wang [email protected]